[Quantization] Fix static quantize runner usage. #26624
Open
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bug: Read input pb files in incorrect order.
- Cause: Python `sorted` was used to acquire sorted input files in
order. However, the input files would be in incorrect order
since "10" is lexicographically smaller than "2".
- Fix: Revise to enumerating indices to read input files.
- Bug: CumSum's output wasn't quantized.
- Cause: CumSum wasn't registered into QDQ registry.
- Fix: Register CumSum with QDQDirect8bitOp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sortedwas used to acquire sorted input files in order. However, the input files would be in incorrect order since "10" is lexicographically smaller than "2".Motivation and Context
Fix two issues in
static_quantize_runnerusage.